[PATCH] hgweb (coal/paper): make file, diff and annotate render faster

Matt Mackall mpm at selenic.com
Fri Nov 21 13:12:21 CST 2008


On Thu, 2008-11-20 at 18:22 -0800, Brendan Cully wrote:
> Here's a patch that reworks the HTML/CSS for paper and coal to make
> file, diff and annotate faster. For file and diff the tables are
> removed entirely, but for annotate I had to keep them to get things to
> align properly against the user at rev column. Consequently annotate's
> speed increase is not nearly as dramatic. If we were willing to
> trim/pad that info to a fixed size (maybe preserving full info in a
> mouseover) we could really improve annotate speed. Here's the
> difference in speed I get on a 100,000 line file, measured in hg from
> start to finish page serving (actual render time is several seconds
> longer for the large numbers):
> 
> unpatched:
> file: 120 seconds
> annotate = 308 seconds
> rev = 120 seconds
> 
> patched:
> file = 28 seconds
> annotate = 220 seconds
> rev = 23 seconds

This seems fine to me.

For anyone not following issue1310, I'll just point out that this is not
about how quickly hgweb generates the page (<10s), but how long it takes
Firefox to display it.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list