[PATCH] Fix rpmlint warnings

Mads Kiilerich mads at kiilerich.com
Sun Nov 23 11:17:07 CST 2008


# HG changeset patch
# User Mads Kiilerich <mads at kiilerich.com>
# Date 1227460622 -3600
# Node ID a031195405693f34714ae0a1010e52370180cfe8
# Parent  8c6251c0882970cbc699818057e9e76802130e38
Fix rpmlint warnings

contrib/mercurial.spec:9: W: hardcoded-path-in-buildroot-tag /tmp/build.%{name}-%{version}-%{release}
A path is hardcoded in your Buildroot tag. It should be replaced by something
like %{_tmppath}/%name-root.

contrib/mercurial.spec:31: W: rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will
break short circuiting.

diff -r 8c6251c08829 -r a03119540569 contrib/mercurial.spec
--- a/contrib/mercurial.spec	Sun Nov 23 18:16:02 2008 +0100
+++ b/contrib/mercurial.spec	Sun Nov 23 18:17:02 2008 +0100
@@ -6,7 +6,7 @@
 Group: Development/Tools
 Source: http://www.selenic.com/mercurial/release/%{name}-%{version}.tar.gz
 URL: http://www.selenic.com/mercurial
-BuildRoot: /tmp/build.%{name}-%{version}-%{release}
+BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root
 
 # From the README:
 #
@@ -28,13 +28,13 @@
 for efficient handling of very large distributed projects.
 
 %prep
-rm -rf $RPM_BUILD_ROOT
 %setup -q
 
 %build
 make all
 
 %install
+rm -rf $RPM_BUILD_ROOT
 python setup.py install --root $RPM_BUILD_ROOT --prefix %{_prefix}
 make install-doc DESTDIR=$RPM_BUILD_ROOT MANDIR=%{_mandir}
 


More information about the Mercurial-devel mailing list