[PATCH] tests: Skip tests if they will fail because of outer repo

Mads Kiilerich mads at kiilerich.com
Wed Nov 26 07:18:22 CST 2008


Dirkjan Ochtman wrote:
> On Wed, Nov 26, 2008 at 03:30, Mads Kiilerich <mads at kiilerich.com> wrote:
>   
>> # HG changeset patch
>> # User Mads Kiilerich <mads at kiilerich.com>
>> # Date 1227666539 -3600
>> # Node ID 45d8c6a75e8f94aeef270589516a0ca8d158564c
>> # Parent  bbfb3bbb92144c110f0a73179cc178892730caa5
>> tests: Skip tests if they will fail because of outer repo
>>     
>
> It seems a bit of overkill, but if we want it, we want it as a hghave.
>   

It might be overkill. But if the tests cry wolf too often then nobody 
will notice new failures - or waste time trying to figure out what is going.

An patch updated to use hghave can be found at 
http://www.bitbucket.org/kiilerix/hg-crew-misc/src/tip/tests-outer-repo

Benoit Boissinot wrote:
> What is the problem with the tests ? Could they be fixed instead ?
>   

Perhaps. But by disabling them where they are known to fail we can 
verify that they pass in all other cases. That makes it easier to fix 
the tests later on and be sure that that doesn't introduce new failures.

test-convert-svn-sink fails for unknown reasons, starting with "abort: 
unresolved merge conflicts (see hg resolve)"
test-glog gets strange failures when testing "from outer space"
test-dispatch explicitly tests for no repo and expects "abort: There is 
no Mercurial repository here (.hg not found)!"
test-extension expects parentui to be None when not cd'ed to a repo dir
test-globalopts tests that implicit -R works correctly

/Mads



More information about the Mercurial-devel mailing list