Information about cloning operations

Dirkjan Ochtman dirkjan at ochtman.nl
Sun Nov 30 08:50:00 CST 2008


On Sun, Nov 30, 2008 at 15:13, Stefano <stefano.tortarolo at gmail.com> wrote:
> As far as I can see the needed information is at revlog.py level (addgroup) but
> there we don't have access to ui, while at an higher level we have
> addchangegroup
> (localrepo.py) but here we can just provide one progress.update before the
> changesets step, another one before the manifests step etc... and the result is
> not so useful.

First, I don't think you should add direct ui knowledge to those
places. Instead, make them call a callback provided by a higher-up
spot, which can then write to the UI as it sees fit.

Second, I think one callback for changesets, one before manifests,
then one for each revlog would still be useful, as it is often the
combined size of the other revlogs which make clone slow, IIRC.

Cheers,

Dirkjan


More information about the Mercurial-devel mailing list