[PATCH] auto rename: best matches and speed improvements PLEASE REVIEW

Benoit Boissinot bboissin at gmail.com
Wed Oct 1 05:46:11 CDT 2008


On Sun, Sep 28, 2008 at 1:48 AM, Herbert Griebel <herbertg at gmx.at> wrote:
> # HG changeset patch
> # User Herbert Griebel <herbertg at gmx.at>
> # Date 1222555608 -7200
> # Node ID d5cab1d3339f14d07723944493f88c9b28b49e28
> # Parent  f29b674cc2210126c2899d94d882c367a8ea64bc
> auto rename: best matches and speed improvements
>
> The auto rename feature of addremove did not rename to the best match
> and was very slow. The new implementation fixes this using all matches
> and using statistics of the file content to speed up the matching.
>
It looks quite nice (I didn't review it in details yet).

You should probably put that in it's own file (similarity.py ?)
And I think this part:
+    # # This code is only for getting the estimator coefficients
+    # # and should never run in a released version

should be removed before the final submission.

regards,

Benoit


More information about the Mercurial-devel mailing list