[PATCH] auto rename: best matches and speed improvements UPDATE4 - all python version

[Petr Kodl]

Herbert,

just out of curiosity - how did it affect the timing on your depo

On Fri, Oct 3, 2008 at 2:21 AM, Herbert Griebel <herbertg at gmx.at> wrote:

> Matt Mackall wrote:
> > On Thu, 2008-10-02 at 17:18 +0200, Herbert Griebel wrote:
> >> Matt Mackall wrote:
> >>> On Wed, 2008-10-01 at 17:57 +0200, Benoit Boissinot wrote:
> >>>>> -static char mdiff_doc[] = "Efficient binary diff.";
> >>>>> +
> >>>>> +typedef struct {
> >>>>> + unsigned int hist[256];
> >>>>> + unsigned int filelen;
> >>>>> +} STATDATA;
> >>> Uh oh. Why did we grow more C code?
> >> If you mean the typedef, this has been fixed already,
> >> please see the latest patch (1 hour ago).
> >
> > No, I mean: there appears to be a lot of new C code to support a
> > relatively obscure feature. This is maybe not a good thing as C code is
> > much more verbose, fragile, and hard to maintain.
> >
> > There is lots of Mercurial code that perhaps should be in C for
> > performance reasons. But I don't think this is in the top 10.
> >
> > So, please: start with everything in Python. When we've got that all
> > merged and happy, we can talk about further performance enhancements.
>
> Patch is here:
> http://www.soundboot.com/hg/autorename_bestmatches_and_speed.patch
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://selenic.com/pipermail/mercurial-devel/attachments/20081003/e00ea274/attachment.htm