Submitting code (was Re: [PATCH] auto rename...)

[Herbert Griebel]

Matt Mackall wrote:
> On Mon, 2008-10-06 at 09:16 +0000, Dirkjan Ochtman wrote:
>> Herbert Griebel <herbertg <at> gmx.at> writes:
>>> - There are currently 5 bugs in the addremove feature (4 minor, 1 major,
>>>   not counting the speed problem), this makes 5 patches.
>>> - For the speed and name matching, -- it's complex --, let's say it's again
>>>   5 larger and not-so-easy-to-understand patches.
>> Assuming this would be just about the same patch size in total, I'd say
>> reviewing 10 separate patches would be *much* easier than reviewing the grand
>> total of your changes. Actually your patch size was the reason I haven't been
>> enable to review it, it's just to much to sort out. I should have mentioned
>> that, maybe, but I wasn't sure whether we had any guidelines on it before.
> 
> Actually, I already asked Herbert to break up his patch way back in
> August:
> 
> http://markmail.org/message/52pxvaxoqwdvzb43

Actually, it is really just the first one of the original 4 patches in this old mail,
so I did split it up, but I went overboard making it faster...


BTW I think one of the minor findings I posted earlier got overlooked:
http://selenic.com/pipermail/mercurial-devel/2008-September/008129.html

It's a problem only on Windows, so maybe it's not relevant. Other commands
like "add" output correctly backslashes, and not forward slashes.