[PATCH] introduce fncache repository layout

Adrian Buehlmann adrian at cadifra.com
Wed Oct 15 18:00:07 CDT 2008


On 15.10.2008 23:20, Benoit Boissinot wrote:
> On Sun, Sep 7, 2008 at 3:33 PM, Adrian Buehlmann <adrian at cadifra.com> wrote:
>> # HG changeset patch
>> # User Adrian Buehlmann <adrian at cadifra.com>
>> # Date 1220789035 -7200
>> # Node ID 81bcb7350ba35ace96078a70720d2253067c2dae
>> # Parent  2365c6d4c330415260821aec67580188022b14e7
>> introduce fncache repository layout
>>
> 
> What is the status of this patch ?

Awaiting feedback/decision from Matt?

It would be pretty tough thing to introduce a repo layout change.

The patch clearly does not fall into the "can be reviewed in 5 minutes"
category.

On the other hand, I've invested a lot of time in it and feel pretty
confident with it. I did a lot of manual testing on Windows.

But introducing a bug with the encodings would be disastrous.

So this is clearly a big risk patch.

If it should be included, synchronizing it with the 1.1 release
might be a good idea.

> Matt do you agree with the approach ? Adrian, did you profile your changes to
> see have they add some negative effects (for example under linux) ?

I haven't done any speed measurements here.

As a side note, I have only very crappy hardware here. Only Windows XP
and FreeBSD 6.2 (testsuite passes on FreeBSD with patch applied to recent crew,
but that doesn't say much).

And I'm reluctant to invest more time in this patch if the
chances are small for its inclusion.



More information about the Mercurial-devel mailing list