[PATCH 1 of 2] Optionally display chains of empty directories in hgweb manifest view

Ry4an Brase ry4an-hg at ry4an.org
Mon Oct 20 14:08:05 CDT 2008


On Mon, Oct 20, 2008 at 01:56:42PM -0500, Matt Mackall wrote:
> On Sat, 2008-10-18 at 20:53 -0500, Ry4an Brase wrote:
> > On Sat, Oct 18, 2008 at 02:22:09PM -0500, Matt Mackall wrote:
> > > On Fri, 2008-10-17 at 01:03 -0500, Ry4an Brase wrote:
> > Without the descending that would have taken 4 more clicks to get to the
> > actual source files.
> 
> Ok, I'm convinced. I'll leave it to Dirkjan to evaluate your
> implementation. Is there any particular reason for it to be optional?

The only reason I can think to make it optional and default to off is
the (admittedly small) computational cost of going through the manifest
and finding the chains of empty dirs.  In most projects (certainly the
case with mercurial itself) there are no chains of empty dirs so the
search for them would be fruitless.

I don't think, however, there's any usability reason to ever want it off
unless someone's screenscraping HTML output, in which case they're in
asking for trouble.

-- 
Ry4an Brase - http://ry4an.org/


More information about the Mercurial-devel mailing list