[PATCH 04 of 14] bookmarks: Mark some missing strings for i18n

Joel Rosdahl joel at rosdahl.net
Sat Oct 25 11:28:12 CDT 2008


David Soria Parra <sn_ at gmx.net> writes:

>>              for bmark, n in marks.iteritems():
>>                  prefix = (n == cur) and '*' or ' '
>> -                ui.write(" %s %-25s %d:%s\n" % (prefix, bmark, repo.changelog.rev(n), hexfn(n)))
>> +                ui.write(_(" %s %-25s %d:%s\n") % (prefix, bmark, repo.changelog.rev(n), hexfn(n)))
>>          return
>
> This doesn't make sense, as you will never translate the displayed
> sha1's, nor do you want to translate the bookmark name.

The markup makes it possible to translate the format string, not the
parts, but I agree that it doesn't make sense in this case.

-- 
Regards,
Joel Rosdahl <joel at rosdahl.net>
Key BB845E97; fingerprint 9F4B D780 6EF4 5700 778D  8B22 0064 F9FF BB84 5E97


More information about the Mercurial-devel mailing list