[PATCH] bugzilla: support sendbugmail.pl

Benoit Boissinot bboissin at gmail.com
Fri Oct 31 13:29:45 CDT 2008


On Fri, Oct 31, 2008 at 06:05:53PM +0000, Jim Hague wrote:
> On Friday 31 October 2008 17:51:01 Benoit Boissinot wrote:
> > On Fri, Oct 31, 2008 at 05:40:42PM +0000, Jim Hague wrote:
> > > My concern is that this would not be backwards compatible with any
> > > existing installation that already has a bugzilla/notify string set in
> > > their config. They will have a string 'something %s' and will get an
> > > unexpected expansion.
> >
> > On the other hand, nothing in the current help mentions how the expansion
> > works. People trying to use their existing config with another bugzilla
> > will have problems too (because it needs to expand 2 items).
> 
> Good point. I had to read the code to see what to put in there.
> 
> I will go ahead on the lines you suggested.

Probably your proposed solution is better. Use a different config item,
installpath and command, maybe you could specify that 'id' and 'user'
will always be the arguments of the command (so you don't need to put a
string to expand in the config).

Handling the backward compatibility would be very nice.

If you're willing to invest some time on this extension, you could
convert the text in comment as a proper help text (see how mq does it at
the beginning of the file).

Thanks for taking care of this extension.

Benoit
-- 
:wq


More information about the Mercurial-devel mailing list