[PATCH] Fix normalize fail on non-lowercase filename (Issue1273)

Benoit Boissinot bboissin at gmail.com
Tue Sep 2 13:28:13 CDT 2008


On Tue, Sep 2, 2008 at 8:13 PM, Adrian Buehlmann <adrian at cadifra.com> wrote:
>
> Maybe Matt can clarify what he tried to achieve with his
> refactoring (when he's back).
>

I've pushed the patch. They're are several issues with the code:

normalize() doesn't get passed a "real" path (but a path relative to
the root of the repo).
So os.path.exists() will fail when cwd != repo.root.
The same issue happens at several other places (and it some cases it
is not necessary to
check if the file exists since we already stat'ed it).

regards,

Benoit


More information about the Mercurial-devel mailing list