[PATCH] Fix normalize fail on non-lowercase filename (Issue1273)

Adrian Buehlmann adrian at cadifra.com
Tue Sep 2 14:42:14 CDT 2008


On 02.09.2008 20:28, Benoit Boissinot wrote:
> On Tue, Sep 2, 2008 at 8:13 PM, Adrian Buehlmann <adrian at cadifra.com> wrote:
>> Maybe Matt can clarify what he tried to achieve with his
>> refactoring (when he's back).
>>
> 
> I've pushed the patch. They're are several issues with the code:
> 
> normalize() doesn't get passed a "real" path (but a path relative to
> the root of the repo).
> So os.path.exists() will fail when cwd != repo.root.

Damn. You're right.

Unless I'm wrong (as always...), this seems to have been introduced with
http://hg.intevation.org/mercurial/crew/rev/9865e15febd0
(which I overlooked myself too when we reviewed that back that...).

> The same issue happens at several other places (and it some cases it
> is not necessary to
> check if the file exists since we already stat'ed it).

Looks like the main repos are not exactly ready for prime time (i.e. a new
release) yet then :(


More information about the Mercurial-devel mailing list