[PATCH] osutil: implementation for Win32

Benoit Boissinot bboissin at gmail.com
Wed Sep 10 18:02:22 CDT 2008


[please don't top-post]

On Wed, Sep 10, 2008 at 06:21:44PM -0400, Petr Kodl wrote:
> There are two more left - both PyList_Append and PyList_Sort can fail ...

Yep, and if we want to check *every* Py*() call there's more work to do.
> 
> and maybe
> 
> s/return ret ? ret : NULL; /return ret;

And probably most of the "return PyErr_NoMemory()" should be replaced by
"return NULL" to propagate the exception instead of returning a memory
error.

Benoit
-- 
:wq


More information about the Mercurial-devel mailing list