[issue1592] crash with hg convert from local CVS repo

[Olivier Andrieu]

New submission from Olivier Andrieu <oandrieu at gmail.com>:

** unknown exception encountered, details follow
** report bug details to http://www.selenic.com/mercurial/bts
** or mercurial at selenic.com
** Mercurial Distributed SCM (version unknown)
** Extensions loaded: color, convert, graphlog, hgk, info, purge, transplant
Traceback (most recent call last):
  File "/usr/bin/hg", line 27, in <module>
    mercurial.dispatch.run()
  File "/usr/lib64/python2.5/site-packages/mercurial/dispatch.py", line 16, in run
    sys.exit(dispatch(sys.argv[1:]))
  File "/usr/lib64/python2.5/site-packages/mercurial/dispatch.py", line 25, in
dispatch
    return _runcatch(u, args)
  File "/usr/lib64/python2.5/site-packages/mercurial/dispatch.py", line 41, in
_runcatch
    return _dispatch(ui, args)
  File "/usr/lib64/python2.5/site-packages/mercurial/dispatch.py", line 372, in
_dispatch
    return runcommand(lui, repo, cmd, fullargs, ui, options, d)
  File "/usr/lib64/python2.5/site-packages/mercurial/dispatch.py", line 247, in
runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/usr/lib64/python2.5/site-packages/mercurial/dispatch.py", line 417, in
_runcommand
    return checkargs()
  File "/usr/lib64/python2.5/site-packages/mercurial/dispatch.py", line 377, in
checkargs
    return cmdfunc()
  File "/usr/lib64/python2.5/site-packages/mercurial/dispatch.py", line 371, in
<lambda>
    d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
  File "/usr/lib64/python2.5/site-packages/mercurial/util.py", line 718, in check
    return func(*args, **kwargs)
  File "/usr/lib64/python2.5/site-packages/hgext/convert/__init__.py", line 199,
in convert
    return convcmd.convert(ui, src, dest, revmapfile, **opts)
  File "/usr/lib64/python2.5/site-packages/hgext/convert/convcmd.py", line 340,
in convert
    c.convert()
  File "/usr/lib64/python2.5/site-packages/hgext/convert/convcmd.py", line 282,
in convert
    self.copy(c)
  File "/usr/lib64/python2.5/site-packages/hgext/convert/convcmd.py", line 253,
in copy
    newnode = self.dest.putcommit(files, copies, parents, commit, self.source)
  File "/usr/lib64/python2.5/site-packages/hgext/convert/hg.py", line 145, in
putcommit
    a = self.repo.commitctx(ctx)
  File "/usr/lib64/python2.5/site-packages/mercurial/localrepo.py", line 844, in
commitctx
    update_dirstate=False)
  File "/usr/lib64/python2.5/site-packages/mercurial/localrepo.py", line 889, in
_commitctx
    fctx = wctx.filectx(f)
  File "/usr/lib64/python2.5/site-packages/mercurial/context.py", line 776, in
filectx
    return self._filectxfn(self._repo, self, path)
  File "/usr/lib64/python2.5/site-packages/hgext/convert/hg.py", line 115, in
getfilectx
    data = source.getfile(f, v)
  File "/usr/lib64/python2.5/site-packages/hgext/convert/filemap.py", line 346,
in getfile
    return self.base.getfile(realname, realrev)
  File "/usr/lib64/python2.5/site-packages/hgext/convert/cvs.py", line 336, in
getfile
    data, mode = self._getfile(file, rev)
  File "/usr/lib64/python2.5/site-packages/hgext/convert/cvs.py", line 327, in
_getfile
    return (data, "x" in mode and "x" or "")
UnboundLocalError: local variable 'mode' referenced before assignment


Adding mode = "" before the while 1: loop seems to fix it.

----------
messages: 8978
nosy: oandrieu
priority: bug
status: unread
title: crash with hg convert from local CVS repo
topic: convert

____________________________________________________
Mercurial issue tracker <mercurial-bugs at selenic.com>
<http://www.selenic.com/mercurial/bts/issue1592>
____________________________________________________