[PATCH] test-convert: issue1585: Hide svn/bzr lib availability

[Mads Kiilerich]

Matt Mackall wrote, On 04/03/2009 09:48 PM:
> On Wed, 2009-04-01 at 12:41 +0200, Mads Kiilerich wrote:
>   
>> # HG changeset patch
>> # User Mads Kiilerich <mads at kiilerich.com>
>> # Date 1238582467 -7200
>> # Node ID d4905be3cfb471c0ae8ab0e8c29cbe1fb96a8741
>> # Parent  026bcd12a0adba249c2e1e1b43ccd4a8207c2e57
>> test-convert: issue1585: Hide svn/bzr lib availability
>>
>> Make the test introduced in d596b1f2935a less specific.
>>     
>
> Don't really like this. 

I also don't like the functionality here, but this is just about a fixed 
bug and a test for that. The test wasn't stable, and this patch makes it 
more stable. So please apply it or remove the test.

Changing converts source detection might be a good idea, but that is a 
different story.

> It would be better if all the sources could do
> their identity test without the tool in question. Then:
>
> - we'd get consistent output regardless of what tools were installed
> - we could say "hey, this looks like a git repo, so you need git
> installed, git"
>   

Yes, that would be better. But I don't think that is feasible for 
Perforce as source. IIRC a Perforce working directory has no direct 
traces of its relation with Perforce. The p4 executable might get the 
information about the working directory root and associated depot from 
an environment variable or the registry, or by reading a config file 
name from an environment variable and searching for a file with that 
name and parsing it. We don't want to duplicate that.

Perhaps auto-detection of perforce and other non-trivial sources should 
be disabled.

/Mads

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3435 bytes
Desc: S/MIME Cryptographic Signature
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090404/0578ebce/attachment.bin