[PATHC] util: don't overwrite os-specific functions with general ones

Matt Mackall mpm at selenic.com
Sat Apr 4 11:40:51 CDT 2009


On Sat, 2009-04-04 at 18:26 +0200, Sune Foldager wrote:
> As Mads Kiilerich noted on IRC a few days ago, some of the 
> windows-specific utility functions defined in win32.py, are subsequently 
> overwritten by util.py, because the latter imports the specific 
> functions before it defines the general ones. The patch moves the 
> functions in question up above the import.

Looks fine.

>  Perhaps we should simply move the import to the bottom, though?

Can't work. We need things like posixfile to get defined. Ideally the
import would be at the top, but that doesn't allow windows or posix to
override things.

-- 
http://selenic.com : development and support for Mercurial and Linux




More information about the Mercurial-devel mailing list