[PATCH] test-convert: issue1585: Hide svn/bzr lib availability

Matt Mackall mpm at selenic.com
Sat Apr 4 16:11:16 CDT 2009


On Sat, 2009-04-04 at 14:12 +0100, Frank A. Kingswood wrote:
> Mads Kiilerich wrote:
>  >> - we'd get consistent output regardless of what tools were installed
>  >> - we could say "hey, this looks like a git repo, so you need git
>  >> installed, git"
>  >>
>  > Yes, that would be better. But I don't think that is feasible for
>  > Perforce as source. IIRC a Perforce working directory has no direct
>  > traces of its relation with Perforce. The p4 executable might get the
>  > information about the working directory root and associated depot from
>  > an environment variable or the registry, or by reading a config file
>  > name from an environment variable and searching for a file with that
>  > name and parsing it. We don't want to duplicate that.
> 
> Actually it is worse than that, it talks to the p4d server because the 
> server knows the names of your local directories that have a P4 
> workspace in them.

Huh. I already patched it. In the p4 case, it requires paths start with
'//' before proceeding. This cleans up tests and matches the docs (which
only mentions such paths).

-- 
http://selenic.com : development and support for Mercurial and Linux




More information about the Mercurial-devel mailing list