[PATCH] verify certificate of https server
Dirkjan Ochtman
dirkjan at ochtman.nl
Wed Apr 8 02:44:33 CDT 2009
On Tue, Apr 7, 2009 at 17:11, Dimitris Glynos <dimitris at census-labs.com> wrote:
> * To do proper validation of the server certificate I had to rely on
> pyopenssl. The openSSL wrappers provided by python 2.5, 2.6 and 3.0
> are "ok" for simple high-level SSL communication, but they're not
> sufficient for the functionality we're after here
> (see mercurial/url.py).
Have you looked at the SSL package that is included in 2.6 but is
available from PyPI for 2.5 (and 2.4, I think)? That would give us a
path to something we don't need dependencies for.
Also, next time please send your patches inline, it's much easier to
review (bonus credit for using patchbomb).
Cheers,
Dirkjan
More information about the Mercurial-devel
mailing list