[PATCH] hgrc.5.txt: Describe the encode/decode filter semantics and the command "!"

Mads Kiilerich mads at kiilerich.com
Wed Apr 15 18:51:19 CDT 2009


timeless wrote, On 04/15/2009 11:23 PM:
> personally, the order of the sentence feels awkward.
>
>> +  The filter command "!" can be used to disable a filter pattern as if
>> +  it hadn't been defined.
>>      
>
> the as if ... part doesn't work. would something like this match your intent:
>
> The filter command "!" causes the previous command for the same
> pattern to be discarded. effectively, the pattern isn't defined.
>    

Thanks for your feedback. While trying to apply your comments I ended up 
rewriting most of it. I think the following is better, but I have 
probably introduced new errors:

--- a/doc/hgrc.5.txt
+++ b/doc/hgrc.5.txt
@@ -107,11 +107,22 @@
    localization/canonicalization of files.

    Filters consist of a filter pattern followed by a filter command.
+  The filter commands for all matching filter patterns are applied
+  in an undefined order.
+
    Filter patterns are globs by default, rooted at the repository
    root. For example, to match any file ending in ".txt" in the root
    directory only, use the pattern "*.txt". To match any file ending
    in ".c" anywhere in the repository, use the pattern "**.c".

+  Specifying a filter command for a filter pattern overrides any
+  previous command specification for that specific pattern, so there
+  can only be one filter command for each filter pattern.
+
+  The filter command "!" does nothing and can be used to effectively
+  drop the filter specification for a pattern. Commands from other
+  matching filters will be applied anyway.
+
    The filter command can start with a specifier, either "pipe:" or
    "tempfile:". If no specifier is given, "pipe:" is used by default.

Comments?

/Mads

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3435 bytes
Desc: S/MIME Cryptographic Signature
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090416/c2b355be/attachment.bin 


More information about the Mercurial-devel mailing list