[PATCH] [stable] [resend #7] issue1577: fix broken test by assuming less about CVS output.

Benoit Boissinot benoit.boissinot at ens-lyon.org
Sat Apr 18 08:45:11 CDT 2009


On Sat, Apr 18, 2009 at 09:11:17AM -0400, Greg Ward wrote:
> # HG changeset patch
> # User Greg Ward <greg-hg at gerg.ca>
> # Date 1238257493 14400
> # Node ID 3c68fb7765e4c598f159530642c657a1f020ffe5
> # Parent  fd7cc930ab8f03b37ac464616e471f4c89f5aa08
> issue1577: fix broken test by assuming less about CVS output.
> Specifically, output of "cvs ci" varies unpredictably across CVS versions,
> so any test that includes the output of "cvs ci" is doomed to fail
> some of the time.  This fixes that by discarding the output of "cvs ci".

Pushed to -stable, thanks.
> 
> diff --git a/tests/test-convert-cvs-synthetic b/tests/test-convert-cvs-synthetic
> --- a/tests/test-convert-cvs-synthetic
> +++ b/tests/test-convert-cvs-synthetic
> @@ -3,8 +3,6 @@
>  # This feature requires use of builtin cvsps!
>  "$TESTDIR/hghave" cvs || exit 80
>  
> -# XXX lots of duplication with other test-convert-cvs* scripts

Is this not true anymore? Could a helper be added in the tests directory?

Benoit

-- 
:wq


More information about the Mercurial-devel mailing list