patchbomb (python email module?) breaks lines after 990 chars

[Martin Geisler]

Christian Ebert <blacktrash at gmx.net> writes:

> * Martin Geisler on Monday, April 20, 2009 at 21:15:12 +0200
>> Christian Ebert <blacktrash at gmx.org> writes:
>>> Further testing reveals, it's not Mutt (and not Mailman either), it's
>>> either patchbomb (I've tested as far back as Mercurial 1.0.2) or
>>> python's email module. Lines are broken after 990 chars ...
>> 
>> That is part of RFC 2822:
>> 
>> 2.1.1. Line Length Limits
>> 
>>   There are two limits that this standard places on the number of
>>   characters in a line. Each line of characters MUST be no more than
>>   998 characters, and SHOULD be no more than 78 characters, excluding
>>   the CRLF.
>> 
>>   [...]
>
> Ah, thanks for the research ... sorry, I guess you knew that by
> heart ;-)

Nope, I'm afraid not :-) But I thought it was strange that it broke just
before 1000 characters, so I guessed it was done on purpose.

I tried looking at patchbomb and it seems to me that we are not encoding
the patches using base64 or quoted-printable -- this is only done for
attached bundles. Maybe we should encode the body as well?

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090420/3c851a49/attachment.pgp