[PATCH 4 of 6] verify: avoid exception on missing file revlog

Henrik Stuart hg at hstuart.dk
Wed Apr 22 02:10:04 CDT 2009


Brodie Rao wrote:
> On Apr 21, 2009, at 1:33 PM, Henrik Stuart wrote:
>>     files = util.sort(util.unique(filenodes.keys() +  
>> filelinkrevs.keys()))
>>     for f in files:
>> +        if not filelinkrevs.has_key(f):
> 
> Could you use "if f in filelinkrevs:" instead? dict.has_key is  
> deprecated in Python 2.6, and the in keyword is a bit more readable.

"if not f in filelinkrevs", but sure. I'll send a revised patch series
that contains this change in a bit.

-- 
Kind regards,
  Henrik Stuart


More information about the Mercurial-devel mailing list