[PATCH] Add ui.width configuration variable

Alexander Solovyov piranha at piranha.org.ua
Sat Aug 1 16:42:06 CDT 2009


On Sun, Aug 2, 2009 at 12:13 AM, timeless<timeless at gmail.com> wrote:
> Alexander Solovyov  wrote:
>> This allows user to define wrapping column for help without using COLUMNS
>> environment variable (which will have effect on other tools).
>
> if we were wordsmithing commit messages, and we aren't, you'd want
> "allows <the|a> user ... define <the> ...
>
> and then the rest would need to be rewritten as "wrapping column for
> help" is quite awkward.

Thanks, rewritten. I'll waiting for comments from crew before resubmitting.

>>  ``verbose``
>>     Increase the amount of output printed. True or False. Default is False.
>> +``width``
>> +    Width to which all generated output will be wrapped.
>
> this seems like a strange and passive way of stating the goal. i'm not
> certain it's actually a problem, but i'd like to see if anyone else
> agrees with my concern. there are other problems too, at least your
> commit message mentioned "columns", this help doesn't....

Actually value of COLUMNS environment variable is used already to determine
width, so I'm not sure how I should mention it here. Maybe something like
"this variable will override COLUMNS env var"?

-- 
Alexander



More information about the Mercurial-devel mailing list