[PATCH] mercurial.ini: provide more useful info

[Steve Borho]

On Tue, Aug 4, 2009 at 3:26 AM, timeless<timeless at gmail.com> wrote:
> Steve Borho wrote:
>> [ui]
>> +; editor used to enter commit logs, etc.  Most any text editor
>> +; will suffice.
>
> I'm not a fan of "most any". Google says 10:1 it should be "almost
> any", or "Most text editors will work".

Sure

>> +; XP    - C:\Documents and Settings\USERNAME\Mercurial.ini
>> +; Vista - C:\Users\USERNAME\Mercurial.ini
>
> You should probably use "Vista or later" and "XP or older" to deal
> with w2k and w7 (which are what I use).

Ok.

>> +; This file is intended to be replaced by the installer on every upgrade.
>
> I'd write "This file will be replaced by the installer on every upgrade."

Yep

> I think you're better served by delivering files to Default User.

Can you elaborate further on this?  If you're talking about installing
the Mercurial.ini elsewhere, it would require changes to both the
installer and system_rcpath() in windows.py.  I was hoping to start
this discussion on the users list, but no one there took the bait.

I rank our options in this order (from least intrusive to most)

1) Put a great big disclaimer on Mercurial.ini, disable nearly
everything in default
2) Install Mercurial.ini as Mercurial.ini.example
3) Install Mercurial.ini under the user who ran the installer or
DefaultUser, which ever works
4) Install Mercurial.ini into a common-user writeable area, modify
system_rcpath() to look for it there.

This patch does option #1, and addresses issue 1751 at the same time.

--
Steve Borho