[PATCH 0 of 2] [mq:qrefresh] Better handle setting/updating the date in the patch

[Yann E. MORIN]

Martin,
All,

On Wednesday 05 August 2009 23:25:49 Martin Geisler wrote:
> You're off to a very good start! :-) Perhaps Dirkjan meant the comma not
> followed by a space:
>     self.comments.insert(patchheaderat + 1,'# Date ' + date)

OK, will fix the existing code as well, then.

> Apart from that and the long lines, I'm not sure how to best manipulate
> these lists.

OK, let's see what I'll be coming back with, then...

> I would like it even better like this:
>                   tmp = 
>                   self.comments = (['# HG changeset patch',
>                                     '# Date ' + date, ''] +
>                                    self.comments)
> That is, you can wrap your code freely within parenthesis.

Ah, OK, will do ( without the useless tmp= assignment, I guess :-) )

[--SNIP: about inlining patches--]
> > That's what I intended to do, using the patchbomb extension as:
> >   hg email --inline [....]
> Ah, that is indeed confusing!
> The --inline flag makes patchbomb send out emails containing attachments
> with Content-Disposition: inline.
[--SNIP--]
> What he meant was that you should not use the --inline flag. That will
> make patchbomb send out mails with the patch included directly as the
> email body text.
[--SNIP--]

OK, will do.

Thanks for the review!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| --==< ^_^ >==-- `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'