[PATCH] add color diff support to record extension

TK Soh teekaysoh at gmail.com
Mon Aug 10 03:24:13 CDT 2009


On Mon, Aug 10, 2009 at 4:18 AM, TK Soh<teekaysoh at gmail.com> wrote:
> On Fri, Aug 7, 2009 at 4:50 PM, Dirkjan Ochtman<dirkjan at ochtman.nl> wrote:
>> On Fri, Aug 7, 2009 at 08:26, TK Soh<teekaysoh at gmail.com> wrote:
>>> # HG changeset patch
>>> # User TK Soh <teekaysoh at gmail.com>
>>> # Date 1249625836 -28800
>>> # Node ID f13256af5362411385e2f4c3a56925428dfa8ddc
>>> # Parent  11a4eb81fb4f4742451591489e2797dc47903277
>>> color: add support for record extension
>>
>> This is apparently against 1.1.2, which doesn't help much.
>
> Oop! I didn't notice I had my stable repo checked out to 1.1.2. Thanks
> for catching this. My apology on the confusion.
>
>> Brodie seems to think (and I would tend to agree, and IIRC Martin,
>> too) that it would be better to introduce a proper inter-extension
>> dependency system first.
>
> Care to share more on the idea? Also, I wonder if we should proceed to
> add the support for Record then fix the inter-extension dependency
> when we are ready, or the other way round.

BTW, I started thinking about this when trying to add the color diff
support into the hgshelve extension: "should the [mq] extension be
requesting for the color support, instead of color extension forcing
it into the [mq] extensions?"

To me the former more 'natural', and it would also make it easier to
enable color support for third-party extensions like hgshelve. Though
the color extension will need to provide the public interface to
support that.

Just some thoughts.



More information about the Mercurial-devel mailing list