[PATCH] add color diff support to record extension

Dirkjan Ochtman dirkjan at ochtman.nl
Mon Aug 10 03:35:33 CDT 2009

On Mon, Aug 10, 2009 at 10:24, TK Soh<teekaysoh at gmail.com> wrote:
> BTW, I started thinking about this when trying to add the color diff
> support into the hgshelve extension: "should the [mq] extension be
> requesting for the color support, instead of color extension forcing
> it into the [mq] extensions?"
> To me the former more 'natural', and it would also make it easier to
> enable color support for third-party extensions like hgshelve. Though
> the color extension will need to provide the public interface to
> support that.

For most stuff we have now, it seems the implementation burden for
coloring output falls squarely in the color extension. If that's a
valid assumption, then it makes much more sense to me to have color
"support" shelve than for shelve to "request" color. Brodie might have
a different idea though, so I'd like to know what he thinks. (And I
think either way could use an extension hooking mechanism.)



More information about the Mercurial-devel mailing list