[PATCH] add color diff support to record extension

[Dan Villiom Podlaski Christiansen]

On 10/08/2009, at 10.35, Dirkjan Ochtman wrote:

> On Mon, Aug 10, 2009 at 10:24, TK Soh<teekaysoh at gmail.com> wrote:
>> BTW, I started thinking about this when trying to add the color diff
>> support into the hgshelve extension: "should the [mq] extension be
>> requesting for the color support, instead of color extension forcing
>> it into the [mq] extensions?"
>>
>> To me the former more 'natural', and it would also make it easier to
>> enable color support for third-party extensions like hgshelve. Though
>> the color extension will need to provide the public interface to
>> support that.
>
> For most stuff we have now, it seems the implementation burden for
> coloring output falls squarely in the color extension. If that's a
> valid assumption, then it makes much more sense to me to have color
> "support" shelve than for shelve to "request" color. Brodie might have
> a different idea though, so I'd like to know what he thinks. (And I
> think either way could use an extension hooking mechanism.)

Wouldn't it be worthwhile to integrate colour support into core?  
Currently, the extension either duplicates the functionality of the  
commands it wraps, or parses their output. It seems likely that having  
the commands themselves add styles would make the implementation both  
simpler and more accurate.

With regard to ‘record’, wouldn't it be an excellent candidate for  
integration as well? After all, it's hardly complex nor dangerous…

--

Dan Villiom Podlaski Christiansen
danchr at gmail.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1943 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090810/c882812a/attachment.bin