[PATCH 3 of 4] diff: add --stat and --stat-width options for diffstat output

Martin Geisler mg at lazybytes.net
Mon Aug 10 11:06:39 CDT 2009


timeless <timeless at gmail.com> writes:

> Brodie Rao wrote:
>> +            raise util.Abort(_('width must be a positive integer or "auto"'))
>> +        if width <= 0: raise util.Abort(_('width must be positive'))
>
> the second message should really be the same as the first.
>
> If I do
>
> --stat-width=-5
>
> and you say "width must be positive", I might try --stat-width=5.5
>
> There's no reason to give me two different errors.

The translators will also thank you for using just one error message.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090810/293fc4da/attachment.pgp 


More information about the Mercurial-devel mailing list