[PATCH 2 of 6] mq: code simplification/beautification in updateheader
Yann E. MORIN
yann.morin.1998 at anciens.enib.fr
Tue Aug 11 12:28:10 CDT 2009
Martin,
All,
On Tuesday 11 August 2009 00:05:12 Martin Geisler wrote:
> I'm not an expert on the mq code, but I think the old code was
> necessary: it updates *all* comments that begin with *any* of the
> prefixes. So a call like
>
> self.updateheader(['From: ', '# User '], user)
>
> will update both the email-like header and the patch header.
Yes, indeed; that's what the current code does. But is it possible that
both fields be present in the same patch? From what I understood, only
one of them could be present.
> Your code
> will exit after updating just one of the headers.
Yes, that was the intended behavior for the change I did, based on the
above assumption...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ___ |
| --==< ^_^ >==-- `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
`------------------------------^-------^------------------^--------------------'
More information about the Mercurial-devel
mailing list