[PATCH 2 of 6] mq: code simplification/beautification in updateheader

Martin Geisler mg at lazybytes.net
Tue Aug 11 16:16:14 CDT 2009


"Yann E. MORIN" <yann.morin.1998 at anciens.enib.fr> writes:

> On Tuesday 11 August 2009 00:05:12 Martin Geisler wrote:
>> I'm not an expert on the mq code, but I think the old code was
>> necessary: it updates *all* comments that begin with *any* of the
>> prefixes. So a call like
>> 
>>   self.updateheader(['From: ', '# User '], user)
>> 
>> will update both the email-like header and the patch header.
>
> Yes, indeed; that's what the current code does. But is it possible
> that both fields be present in the same patch? From what I understood,
> only one of them could be present.

Okay, I didn't know that, I was just unsure if the change in
functionality was done on purpose.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090811/eab87cdb/attachment.pgp 


More information about the Mercurial-devel mailing list