[PATCH] revlog: add explicit type check to _match()

[Dan Villiom Podlaski Christiansen]

On 12/08/2009, at 12.15, Dirkjan Ochtman wrote:

> On Wed, Aug 12, 2009 at 12:13, Dan Villiom Podlaski
> Christiansen<danchr at gmail.com> wrote:
>> # HG changeset patch
>> # User Dan Villiom Podlaski Christiansen <danchr at gmail.com>
>> # Date 1250071313 -7200
>> # Node ID 503f9a6eacfa9afd12493d5cbf1707c3d2046504
>> # Parent  a4a996cce137e1a328f6cd384d46b97e62fd26fe
>> revlog: add explicit type check to _match().
>
> Have you tested lookup performance with this? I think there's a lookup
> test in contrib/perf.py.

I didn't see much difference; both took about 8,5-9ms on my G4.

> % HGRCPATH=/dev/null PYTHONPATH=build/lib.macosx-10.5-ppc-2.6/ 
> mercurial:contrib:. python2.6 ./hg --config extensions.perf=contrib/ 
> perf.py perflookup 234a230cc33b
> ! result: 20
> ! wall 0.008034 comb 0.010000 user 0.010000 sys 0.000000 (best of 295)
> ! wall 0.032856 comb 0.008881 user 0.008678 sys 0.000203 (average)

(I changed perf.py a bit to make it  run longer and calculate the  
average. The changes are attached below.)

--

Dan Villiom Podlaski Christiansen
danchr at gmail.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: perf.diff
Type: application/octet-stream
Size: 920 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090812/ed4e79c2/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1943 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090812/ed4e79c2/attachment.bin