[PATCH] Fix issue 1719, inotify dirstate when dirty (v2: improved matching + extended test)

[Benoit Boissinot]

On Mon, Aug 17, 2009 at 09:19:35AM +0200, Simon Heimberg wrote:
> Hello Benoit
> 
> Nicolas rejected to "disable" inotify when the dirstate is dirty. (This
> was my first fix, a one line patch.)
> 
> The bug is currently only triggered with mq (inside of repo.commit). But
> I did not check all extensions, especially not the external ones. And I
> do not know the feature development.
> 
> How can I do benchmarking? There is not perfqpu command in perf.py.
> I created a mq patch containing revisions 59bb11a97fe5 to f7c334e810c2
> of hg crew. Then I executed "time hg qpu". The results are below. Almost
> the same. How can I do better benchmarking?
> 

The best mq patch is probably still the time for applying the -mm quilt
from the kernel:
- clone the kernel repo (can take a long time) from http://www.kernel.org/hg/linux-2.6
- update to a tag
- download the corresponding broken-out:
  http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.28-rc2/2.6.28-rc2-mm1/
- copy it into .hg/patches

and then you have something to benchmark on a repo where inotify
matters.

regards,

Benoit

-- 
:wq