[PATCH] mq: modify qheader to allow setting header contents

Peter Williams pwil3058 at bigpond.net.au
Tue Aug 18 18:45:08 CDT 2009

On 19/08/09 02:38, timeless wrote:
> On Tue, Aug 18, 2009 at 3:04 PM, Peter Williams<pwil3058 at bigpond.net.au>  wrote:
>> -    """print the header of the topmost or specified patch"""
>> +    """print or modify the header of the topmost or specified patch
> i'm not sure why (and i'm aware the line isn't something you wrote
> originally), but for some reason, i'd favor "specified or topmost
> patch". kinda curious to hear if others agree.

I agree and would probably go further and make it something like 
"specified (or topmost if none specified) patch".

>> +    -u/--user and -d/--date can be used to set the (given) user and
>> +    date, respectively. -U/--currentuser and -D/--currentdate set user
>> +    to current user and date to current date.
> i don't think parentheses around given are appropriate, and might
> prefer 'specified' instead of 'given'

I agree with both of these suggestions but would add that the reason I 
chose the wording (that I did) was for compatibility with existing 
wording (actually it's cut and paste).  So the original should also be 
modified.  Perhaps a variable containing the wording could be used so as 
to maintain consistency should any further changes be made.

Peter Williams                                   pwil3058 at bigpond.net.au

"Learning, n. The kind of ignorance distinguishing the studious."
  -- Ambrose Bierce

More information about the Mercurial-devel mailing list