[PATCH 1 of 3] update: tests for branching

Gilles Moris gilles.moris at free.fr
Fri Aug 21 15:16:07 CDT 2009

On Fri August 21 2009 08:20:30 Stuart W. Marks wrote:
> Another good point. The main intent of the test is to test updating across 
> branches. I threw in the "linear" update case as well but as you observe this 
> only updates to a descendant but not an ancestor. At this point I'm leaning 
> toward correct the comment to reflect more accurately what the test actually 
> does, but I'm willing to add more tests if people think they are useful.

I would tend to agree: update to ascendant/descendant are probably more relevant
for merge tests.

> After some further reflection I think it's probably reasonable to cut down the 
> number of test cases in the third patch. Not only is the behavior of the 
> cross-named-branches vs same-named-branches the same, but also the -c and -C 
> options have no effect when the repo has no uncommitted changes. I'd like to 
> hear reviewers' thoughts on this before proceeding though.

I would keep them:
- It is always good to have a good coverage.
- Bugs are not always obvious
- Even if this is sufficient now, the code can change and make them important in
  the future.
- Now that they are here, why not keep them ...

But this is just one opinion.


More information about the Mercurial-devel mailing list