[PATCH 0 of 2 RFC] Introduce defaultdict in mercurial?

[Dirkjan Ochtman]

On Fri, Aug 21, 2009 at 17:43, Nicolas Dumazet<nicdumz at gmail.com> wrote:
> (As a side question: what guidelines are there for submitting rather long
> refactoring patches? I understand that the second patch is probably quite long
> and hard to review; does it makes sense to split the commit per filegroups,
> maybe?)

If it's a simple, local, refactoring, just showing one big patch will
usually do. In some cases, splitting up mercurial vs hgext also works.
Splitting it up too much (over file groups, or one extension at a
time, or whatever) usually only increases the review effort.

Do we have any idea of how performance of your 2.4 defaultdict impl
compares to the standard setdefault idiom? I'd guess that it's about
the same, but it would be nice to have confirmation.

Cheers,

Dirkjan