[PATCH] mq: Add mechanism for setting patch header contents

Dirkjan Ochtman dirkjan at ochtman.nl
Sat Aug 22 02:28:05 CDT 2009


On Sat, Aug 22, 2009 at 08:46, Peter Williams<pwil3058 at bigpond.net.au> wrote:
> # HG changeset patch
> # User Peter Williams <pwil3058 at bigpond.net.au>
> # Date 1250923379 -36000
> # Node ID c4c1c8bd697f0e62c546740b8dc84b65990f2a6a
> # Parent  37042e8b3b342b2e380d8be3e3f7692584c92d33
> mq: Add mechanism for setting patch header contents
>
> Modify 'qheader' by adding options rather than creating a new command.
> Make sure that users will not be surprised by changes to 'qheader'.
> Modification may be made to both applied and unapplied patches.
> If the patch is applied, the change is not propagated into the change
> set representing the patch but the user is warned that a refresh is
> required for the propagation to occur.
>
> Signed-off-by: Peter Williams <pwil3058 at bigpond.net.au>

We don't do signed-off-by taglines in Mercurial.

It occurs to me that your patch adds 4 levels of indentation to
something that's already indented at one or two levels. That may well
be alright, but it does make me a bit queasy about your patch. I'd
also prefer to disallow this for applied patches; if you're doing it
for applied patches, it seems like you might have newer patch data in
your repo but newer metadata in the patch file, which seems ugly and
error-prone.

Cheers,

Dirkjan



More information about the Mercurial-devel mailing list