[PATCH stable] dirstate.write: don't ignore stat data if mtime is in the future (issue1790)

Dirkjan Ochtman dirkjan at ochtman.nl
Sat Aug 22 03:24:13 CDT 2009


On Fri, Aug 21, 2009 at 17:50, Adrian Buehlmann<adrian at cadifra.com> wrote:
> # HG changeset patch
> # User Adrian Buehlmann <adrian at cadifra.com>
> # Date 1250857043 -7200
> # Node ID cab3d06cc7ee4672d9bfd28ab38e568de80473e9
> # Parent  f4f17d5695d2972ae4126f5a676a1e573ededaa1
> dirstate.write: don't ignore stat data if mtime is in the future (issue1790)
>
> This change narrows the race guard that was introduced by af3f26b6bba4
> ("dirstate: ignore stat data for files that were updated too recently")
> to not discard the _map entry's stat data if the mtime is in the future.
>
> Without this change, status locks files having odd mtimes in the future
> into the 'unset' state, causing needless file compares later (admittedly
> harmless), but also inflicting highly irritating sticky effects on
> tools/plugins that directly read .hg/dirstate (e.g. TortoiseHg).

I've pushed it to crew-stable as 1a7bcf58ba56. Thanks!

Cheers,

Dirkjan



More information about the Mercurial-devel mailing list