[PATCH] mq: Add a new command, 'qrebase', to obviate need for 'qsave'

[Augie Fackler]

On Aug 25, 2009, at 7:42 AM, Adrian Buehlmann wrote:

> [On 25.08.2009 10:57, Peter Williams wrote:
>> I am.  But I'm using mq terminology and rebase isn't part of mq.
>
> Funny, but with your proposed patch, you exactly do that:
>
> You implicitly make rebase a part of mq by making mq dependent on
> rebase.
>
> From your proposed patch:
>
> On 25.08.2009 08:43, Peter Williams wrote:
>> +    from hgext import rebase
>> +    opts['base'] = 'qbase'
>> +    return rebase.rebase(ui, repo, **opts)
>
> There, you _rebase_ the qbase.
>
> BTW, how is that difficult to explain? "Rebasing the qbase"
> seems pretty clear. You rebase the queue.
>
> 'Reparenting' the qbase sounds rather silly...
>
> An entirely different question is whether it is a good thing
> to make the mq extension dependent on the rebase extension.
>
> Which is probably a much bigger issue than the name of the
> proposed new command.

Honestly, I'm -1 on having:

1) yet another obscure mq subcommand that very few will use
2) reinventing the wheel when we can just state somewhere in the  
{mq,rebase} docs that you can do (eg) hg rebase -s qtip -d tip and  
it'll magically DTRT even though there's an mq, since rebase is  
already mq safe.

Just my 2¢.

Augie


>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel