[PATCH] Fix issue 1719, inotify dirstate when dirty (v2: improved matching + extended test)

[Benoit Boissinot]

On Wed, Aug 26, 2009 at 09:13:21PM +0000, Simon Heimberg wrote:
> Benchmarking showed that qpush with inotify is not quicker than without
> inotify. There is a small gain when the CPU (or the disc?) is on high
> load.
> 
> Does this mean the one line patch (which disables inotify on dirty
> dirstate) is preferred?

If possible I'd prefer a benchmark that tests the two possible
approaches, with inotify enabled.

If you can't do it, maybe you can put your .hg/patches directory online
and Nicolas could have a look?
> 
> Details of benchmarking:
> kernel repo at v2.6.26-rc2
> applying all patches from the -mm quilt (executed qref for all patches
> which applied with a warning)
> 
> execute command:
> (hg st # for starting inotify)
> time hg qpu -a -q
> (hg qpo -a -q)
> 
> high l.	w inotify	w/o inotify	low l.	w inotif	w/o inotify
> real	1m32.836s	2m7.508s		1m5.765s	1m0.737s
> user	0m36.166s	0m36.614s		0m36.826s	0m37.55s
> sys	0m2.916s	0m3.576s		0m2.836s	0m3.224s

Thanks,

Benoit

-- 
:wq