[PATCH] color: add support for terminfo-based attributes and color
duvall at comfychair.org
Wed Aug 26 21:05:11 CDT 2009
On Wed, Aug 26, 2009 at 10:52:25AM -0400, Brodie Rao wrote:
> - Is ecma48 the best name for the setting? I think it's a bit
> cryptic to anyone who hasn't read up on terminal control sequences.
I've changed it to "terminfo" (and the internal variable to match). I'm
not convinced this is the clearest, either, but I don't have a better idea.
Perhaps make it "ansi" and have it default to False?
> - Can effect_str() be moved out of render_effects()? It doesn't use
> anything in the outer scope.
Sure; I put it inside not for scoping, but just because it was private.
> - Can the curses setup code be moved into its own function?
> - Wrap long lines to 79 characters or less.
> - Include the rationale for the patch in the commit message.
Done (for any of my code) and done.
New patch (in patchbomb format) coming up.
More information about the Mercurial-devel