[PATCH 2 of 2] extensions: pass ui arguement to extsetup if accepted
Martin Geisler
mg at lazybytes.net
Sat Aug 29 04:21:38 CDT 2009
Brodie Rao <dackze at gmail.com> writes:
> try:
> util.checksignature(extsetup)(ui)
> except util.SignatureError:
> extsetup()
>
> Does extsetup really need to be changed, though? With uisetup being
> called after all extensions are loaded, is it even useful anymore?
My feeling is no -- extsetup is called right after uisetup, so the code
can just go into uisetup. That was what I did for the color extension
and it simplified it quite a bit.
So I suggest we pull out the extsetup(ui) code again unless someone can
come up with a good argument to keep it?
--
Martin Geisler
VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090829/dd1ee3c0/attachment.pgp
More information about the Mercurial-devel
mailing list