[PATCH 0 of 6] C: spaces and refcounting

Matt Mackall mpm at selenic.com
Mon Aug 31 21:25:51 CDT 2009


On Thu, 2009-08-27 at 13:09 +0000, Nicolas Dumazet wrote:
> Hello -devel!
> 
> 6 patches:
> 
> First one about identation. I was surprised to find a majority of tabs in our
> C code. Do we have specific coding guidelines for C?
> Anyway, the first patch unificates indentation: use tabs everywhere instead of
> a majority of tabs and a few spaces.
> (I don't mind chosing tabs, or spaces, as long as we're consistent throught the
> C code)
> 
> And then other patches are about cleaning up reference counts when returning /
> bailing out from CPython functions. Only #4 addresses a real refcount bug, the
> others are cleanups.

It's a bad idea to mix cleanups and real fixes, either in the same patch
or the same patch series. If I just want your fix but don't like your
other cleanups, it's unlikely to apply. In general, the longer your
patch series is, the less likely someone's going to look at all of it
and the more likely you'll need to resend when they do.

-- 
http://selenic.com : development and support for Mercurial and Linux




More information about the Mercurial-devel mailing list