[PATCH 0 of 4 bfiles] implement verify method for sshstore

[Greg Ward]

On Tue, Dec 1, 2009 at 2:05 PM,  <david.douard at logilab.fr> wrote:
> here a new set of patches to implement the verify method of hg-bfiles's sshstore. I splitted the actual implementation of the method for the sshstore from a required refactoring to basestore.verify so we can factorize most of the code.

Great, thank you!

I pushed your first three patches with minor changes:

changeset:   101:46d23f871b50
user:        David Douard <david.douard at logilab.fr>
date:        Tue Dec 01 19:15:58 2009 +0100
summary:     store/localstore: refactor verify() to reduce duplicate code.

changeset:   102:fe560c8055ce
user:        David Douard <david.douard at logilab.fr>
date:        Tue Dec 01 19:15:58 2009 +0100
summary:     sshstore: support verification

changeset:   103:75af14d6d5a4
user:        David Douard <david.douard at logilab.fr>
date:        Tue Dec 01 19:15:58 2009 +0100
summary:     tests: factor out checkssh() function from test-sshstore to common.

But your test-sshstore-verify had too much duplicate for my taste.  So
I refactored the existing test for bfverify, which made testing
bfverify for sshstore trivial:

changeset:   104:632af2bfbfd0
user:        Greg Ward <greg at gerg.ca>
date:        Sun Dec 06 15:26:17 2009 -0500
summary:     Refactor bfverify tests.

changeset:   105:9bd30f55337d
tag:         tip
user:        Greg Ward <greg at gerg.ca>
date:        Sun Dec 06 15:30:10 2009 -0500
summary:     Add test-verify-ssh (based on a patch by David Douard).

Now I just need to figure out why bfverify is so horribly slow.  (I
ran it once on my 104,000-changeset "real" repository at work, and it
took *hours* just to verify existence of all revisions of all big
files.  Awful!  I'm sure I got the basic algorithm wrong, but have not
taken the time to figure out what I screwed up.)

Greg