mercurial spec broken

Martin Geisler mg at lazybytes.net
Thu Dec 10 16:38:45 CST 2009


Dan Villiom Podlaski Christiansen <danchr at gmail.com> writes:

> On 7 Dec 2009, at 10:12, Martin Geisler wrote:
>
>> Gilles Moris <gilles.moris at free.fr> writes:
>>> 
>>> The contrib/mercurial.spec file has been broken by the rename of
>>> bash/zsh completion scripts. This can be fixed but ...
>>> 
>>> As they are now handled by setup.py, they are by default already in
>>> the RPM with a separate path:
>> 
>>> /usr/share/bash_completion.d/hg
>>> /usr/share/zsh/site-functions/_hg
>>> 
>>> when they were previously in:
>>> /etc/bash_completion.d/mercurial.sh
>>> /usr/share/zsh/site-functions/_mercurial
>>> 
>>> So how do you see it:
>>> - rename the files again and change the setup.py again to match the
>>>  spec file
>>> - have them on both locations
>>> - get rid of the previous location but break compatibility
>>> - other / hybrid solution
>> 
>> Well, I talked about it with Mads yesterday, and the more I look at
>> it, the more it seems to me that we should not let setup.py install
>> such things. It just seems like there are too many special cases for
>> us to know them all in a single setup.py.
>
> I agree that we shouldn't install the completion files. Originally, I
> chose a bunch of files somewhat arbitrarily to test the functionality,
> without knowing much about whether installing each one was a good idea
> or not.

I have undone this this change:

  http://hg.intevation.org/mercurial/crew/rev/873d9b9a7bac

(see the bottom of the page)

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20091210/7638a6b0/attachment.pgp>


More information about the Mercurial-devel mailing list