[PATCH 0 of 3] hunting down inotify bugs

[Gilles Moris]

On Friday 11 December 2009 08:39:03 am Nicolas Dumazet wrote:
> Hello!
>
> Here are three patches fixing inotify bugs found thanks to --inotify test
> runs. If you want to try to assess yourself the changes with those tests,
> you should use:
>   * python run-tests.py --inotify --blacklist inotify-failures test-*
>   * python run-tests.py test-inotify*
>
> The first test run will still expose inotify failures/tests not made for
> inotify, even after applying this serie. You should of course compare
> before/after relative results :)
>
> If you are curious about the remaining failures,
> http://bitbucket.org/nicdumz/mercurial-crew-mq/wiki/Home might help explain
> a few.
>
> Thanks,
> Nicolas.
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel

I cannot comment too much on the code itself, as I did not deep dive in 
inotify yet, but it seems effective:
# Ran 340 tests, 33 skipped, 45 failed.
# Ran 8 tests, 0 skipped, 0 failed.
to
# Ran 340 tests, 33 skipped, 24 failed.
# Ran 8 tests, 0 skipped, 0 failed.
based on 359c56728257.

Nearly 2x improvement, with some code simplification.

Thanks for your hard work.
Gilles.