[PATCH] graphlog: fix output when both a limit and a path are provided

[Nicolas Dumazet]

2009/12/16 Martin Geisler <mg at lazybytes.net>:
>> Any reason to use sys.maxint instead of None?
>
> The cmdutils.loglimit function uses sys.maxint and the limit argument is
> parsed by that function in the caller.
>
> I agree with you that using None would be better (there's no sys.maxint
> in Python 3 and it generally feels weird to use sys.maxint). I talked
> with Nicolas about it on IRC and he promissed to send a cleanup patch
> after this one which will switch away from sys.maxint in general.

Thanks for explaining :)

>>
>> Looks good to me.
>
> It's definitely an improvment and we're closer to the behavior of log.
> But there are still some small flaws if you both narrow the revision
> range and add a limit:
>
>  hg glog i18n/hggettext -r 8000:8600 -l 1
>  hg log i18n/hggettext -r 8000:8600 -l 1
>
> I would be okay with putting in the current patch and fix those in a
> later patch.
>

So please do not push it yet. Actually, that behavior is a regression,
it just means that there are not enough tests. I dont really want this
in :)



-- 
Nicolas Dumazet — NicDumZ