[PATCH 0 of 6] bookmarks: propertycache and cleanups

[Martin Geisler]

David Soria Parra <sn_ at gmx.net> writes:

> On 2009-12-21, Nicolas Dumazet <nicdumz at gmail.com> wrote:
>> Hello!
>>
>> Bookmarks is caching manually _bookmarkcurrent and _bookmarks. For clarity, I
>> find it much more easier to use propertycache().
>> The code is simplified and easier to read.
>>
>> I am not sure of how much of the namespace of localrepo is allowed to be
>> cluttered by extension helper functions. If we prefer keeping the logic
>> outside of repo subclasses, the last patch can be dropped from this serie.
>
> This series looks fine for me, I think it should go into crew.

Yep, I agree! I've pushed them as dc5b5cc5ca34, cb3f6da91646,
c03f467423f3, b6fcb5c55884, and be041d6714ed.

The second patch was bad -- bookmarks_repo was not defined in the
top-level parse function... :-) But it didn't matter since patch six
moved the code into the class definition. When moving the code, I also
changed the references to repo to self.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20091221/070af27c/attachment.pgp>