[PATCH] bookmarks: added invalidate() to bookmark_repo

Nicolas Dumazet nicdumz at gmail.com
Mon Dec 21 20:36:29 CST 2009


Hello Paul!

2009/12/18 Paul Molodowitch <paulm at luma-pictures.com>:
> Submitting a patch to make bookmark_repo override the invalidate method to
> erase cached bookmark info.

Thanks for your submission!

Useful information for next time: the folks here usually use patchbomb
extension to mail their patches, and _inline_ the patches. We prefer
this over attaching patches because it allows reviewers to quote the
code :)

>
> This way, programs (such as gui's) will not have to manually reset the
> cached bookmark information.

The patch looks good to me. It needs to be updated [ setattr(self,
attr, None) should be changed to delattr(self, attr) after my changes
in crew ], but otherwise it is alright to me.

>
> - Paul
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>
>



-- 
Nicolas Dumazet — NicDumZ


More information about the Mercurial-devel mailing list